⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo.
Please turn off Keep my email addresses private setting in your account.
See LLVM Developer Policy and LLVM Discourse for more information.

✅ With the latest revision this PR passed the C/C++ code formatter.

@adam-yang Sorry for my delay but currently I am on PTO.

A couple of points:

This PR also fixes two bugs in LogicalView:

DW_AT_ranges are not being read correctly
DW_AT_high_pc for scopes are treated as inclusive

Can those fixes being on a different PR?

adds a new tool llvm-debug-info-check, which prints out debug info in an easily testable format.

Instead of adding a new tool, can the new functionality be added to the llvm-debuginfo-analyzer? For example by adding --check option to generate the new/simple LogicalView. I think the PR has already the walking code.

@adam-yang Sorry for my delay but currently I am on PTO.

A couple of points:

This PR also fixes two bugs in LogicalView:
DW_AT_ranges are not being read correctly
DW_AT_high_pc for scopes are treated as inclusive

Can those fixes being on a different PR?

adds a new tool llvm-debug-info-check, which prints out debug info in an easily testable format.

Instead of adding a new tool, can the new functionality be added to the llvm-debuginfo-analyzer? For example by adding --check option to generate the new/simple LogicalView. I think the PR has already the walking code.

Thank you for looking at this change while on PTO!

Yes. There is another PR related to this change. Once it lands I'll split this PR up, and add the "check" functionality as a part of llvm-debuginfo-analyzer instead.

@adam-yang Sorry for my delay but currently I am on PTO.

Yes. There is another PR related to this change.

Is that PR being reviewed?

Once it lands I'll split this PR up, and add the "check" functionality as a part of llvm-debuginfo-analyzer instead.

That will be great.
I am back from PTO next Monday.